Remove BiCouplingScheme, merge MultiCouplingScheme and ParallelCouplingScheme#13
Closed
BenjaminRodenberg wants to merge 35 commits into1171-write-data-when-subcycling-is-usedfrom
Closed
Remove BiCouplingScheme, merge MultiCouplingScheme and ParallelCouplingScheme#13BenjaminRodenberg wants to merge 35 commits into1171-write-data-when-subcycling-is-usedfrom
BenjaminRodenberg wants to merge 35 commits into1171-write-data-when-subcycling-is-usedfrom
Conversation
* Use same signatures for addDataToSend and addDataToReceive * Use _readDataVector, _sendDataVector and _m2ns in both classes (even, if there is only a single item) * Move common functionality into BaseCouplingScheme
17 tasks
* Use MultiCouplingScheme for ParallelExplicitCouplingScheme * Update tests * Remove ParallelCouplingScheme class
* Merge Multi- and ParallelCouplingScheme * Remove BiCouplingScheme in favor of SerialCouplingScheme * Simplifies class hierarchy and limits amount of duplicate code
8 tasks
Owner
Author
|
We decided to drop precice#1432. Continue working in precice#1414 |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Motivation and additional information
Might be useful for implementation of precice#1414. Simplifies class design, but is also a major redesign.
Author's checklist
make changelogif there are user-observable changes since the last release.make formatto ensure everything is formatted correctly.Reviewers' checklist