Skip to content

Store from/toWaveform in DataContext#1

Merged
BenjaminRodenberg merged 87 commits intoprototype_waveform_read_writefrom
data-context-to-waveform-context
Nov 22, 2021
Merged

Store from/toWaveform in DataContext#1
BenjaminRodenberg merged 87 commits intoprototype_waveform_read_writefrom
data-context-to-waveform-context

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown
Owner

@BenjaminRodenberg BenjaminRodenberg commented Aug 3, 2021

Reading data requires us to also map Waveforms. This PR provides a draft for the implementation.

@BenjaminRodenberg BenjaminRodenberg self-assigned this Aug 3, 2021
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Aug 3, 2021
Closed
34 tasks
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
4bcc056 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
b3c9d95 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
eca2065 
…eform-context
@BenjaminRodenberg
Many failing tests, but assertions pass.
33a198d
@BenjaminRodenberg
Add missing read functions.
08e2b6e
@BenjaminRodenberg
Sample waveform before reading.
659504b
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
8fdd0f9 
…eform-context
@BenjaminRodenberg
Fix, if no read mapping exists.
2e798eb
@BenjaminRodenberg
translate comment.
c1f0d4a
@BenjaminRodenberg
Add test for more fine-grained detection of error.
47eb295
@BenjaminRodenberg
Fix config.
e7ecea5
@BenjaminRodenberg
Reset data at the correct place.
b15b3ad
@BenjaminRodenberg
Fix communication of write/read data.
daac051
@BenjaminRodenberg
Put data exchange to the right place.
ec71e6d
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
3b81b80 
…eform-context
@BenjaminRodenberg
Fix actions and cleanup DataContext and names.
b2c3c43
@BenjaminRodenberg
Remove unrequired functions and members.
dbd06e9
@BenjaminRodenberg
Comment out sampleAt, since this leads to failure of PreciceTests/Ser…
98391e7 
…ial/ActionTimingsImplicit
@BenjaminRodenberg
Refactoring.
dc25e7c
@BenjaminRodenberg
Fix.
b1bcab5
@BenjaminRodenberg
Add logger and assertion.
c70f644
@BenjaminRodenberg
Fix when actions are performed.
1d7c1a5
@BenjaminRodenberg
Fix waveform initialization.
b826af5
@BenjaminRodenberg
Add security checks.
9166e85
@BenjaminRodenberg
Cleanup the diff.
b7b7dbb
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
20028b6 
…eform-context
@BenjaminRodenberg
Implement linear interpolation. Update some tests.
2d8429e
BenjaminRodenberg added a commit that referenced this pull request Oct 8, 2021
@BenjaminRodenberg
Reorder tests and synchronize with #1
f512115
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
4c300e9 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
5ac32d7 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
317b32a 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
811d190 
…eform-context
@BenjaminRodenberg
Revert "Remove test not belonging in this PR."
dd7f5ad 
This reverts commit c89638b.
@BenjaminRodenberg
Add missing config.
d74c2cb
@BenjaminRodenberg
Move InitializeDataTests into independent file.
a0c1a0f
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
fef3251 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
8c8dc08 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
6d5c648 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
75341c6 
…eform-context
@BenjaminRodenberg
Merge branch 'prototype_waveform_read_write' into data-context-to-wav…
182e153 
…eform-context
@BenjaminRodenberg
Add test for serial implicit coupling.
fb8816f
@BenjaminRodenberg
Fix initialization.
33a3989
@BenjaminRodenberg
Simplify tests.
d5f4042
@BenjaminRodenberg
Reorder tests and add stub for parallel implicit.
8cfaef3
@BenjaminRodenberg BenjaminRodenberg mentioned this pull request Nov 3, 2021
Open
@BenjaminRodenberg
Copy link
Copy Markdown
Owner Author

BenjaminRodenberg commented Nov 9, 2021

Current state:

  • Initialize data and read waveforms works as expected.
  • The tests illustrate usage and expected output.
  • The actual implementation is still very verbose, but works.

BenjaminRodenberg
BenjaminRodenberg commented Nov 9, 2021
View reviewed changes
@BenjaminRodenberg BenjaminRodenberg merged commit 89bc169 into prototype_waveform_read_write Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@BenjaminRodenberg BenjaminRodenberg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@BenjaminRodenberg