fix(tests): align contract + drift-test pins with the two claude-cli backends (#88 fix-forward)#90
Merged
Conversation
…wo claude-cli backends (#88 fix-forward) #88 landed via auto-merge before two late CI jobs concluded, leaving main red on exactly the two pins its change was meant to move: - plugin-registration contract: anthropic cliBackendIds pinned to ['claude-cli'] — now ['claude-cli', 'claude-cli-ultracode'] (the ownership the manifest deliberately declares post-#88). - anthropic-manifest-cli-backends.test.ts: passing the raw PluginManifest into listSetupCliBackendIds fails tsgo (PluginManifestRecord requires providers/cliBackends non-optional). Assert the shipped manifest list directly + call the resolver with a normalized record. Gates: tsgo:core:test exit 0; vitest plugin-registration.contract + anthropic-manifest suites 91/91. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red — #88 auto-merged before its two late CI jobs (
check-test-types,checks-fast-contracts-plugins-a) concluded. This fixes both failures forward; opened ready (not draft) so it lands immediately.plugin-registration-contract-cases.ts: anthropiccliBackendIdspin['claude-cli']→['claude-cli', 'claude-cli-ultracode']— the exact ownership drift fix(plugins): ultracode harness durability — declare claude-cli-ultracode in the anthropic manifest #88 introduces on purpose (comment added pointing at the drift-guard test).anthropic-manifest-cli-backends.test.ts: tsgo type error (rawPluginManifestvsSetupDescriptorRecord) — assert the shipped manifest's list directly and calllistSetupCliBackendIdswith a normalized record.Gates local:
pnpm tsgo:core:testexit 0 · vitest contract + manifest suites 91/91.Lesson applied: local vitest doesn't typecheck and I didn't run the contract suite pre-merge — both now in the touched-suite set for any future manifest change.
🤖 Generated with Claude Code