feat(build-info): self-report the bench tag lineage via git-describe (durable version honesty)#85
Merged
Conversation
…e bench tag lineage The bench fork deliberately keeps package.json version at the upstream base (2026.6.2) and carries the bench release identity in the git TAG (e.g. 2026.6.8-bench.3) — so build-info version alone cannot tell you which bench release a running build is. This bit the Briggs go-live and the 2026-06-23 gateway cutover (--version -> 6.2 vs the real 6.8-bench.3 in the brew Cellar). Add an additive 'release' field stamped from `git describe --tags --always --dirty` (e.g. v2026.6.8-bench.3-3-gd401e877d6), so a running build honestly self-reports its lineage: nearest bench tag + commits-ahead + short sha, plus a -dirty marker if built from an uncommitted worktree (a bonus floating-build signal). The load-bearing version field (npm-shrinkwrap / release-checks / npm-publish all key off it) is left untouched. GIT_RELEASE env override for hermetic builds. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
LightDriverCS
marked this pull request as ready for review
June 23, 2026 07:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds an additive
releasefield todist/build-info.json, stamped fromgit describe --tags --always --dirty:{ "version": "2026.6.2", "release": "v2026.6.8-bench.3-3-gd401e877d6", "commit": "d401e877…", "builtAt": "…" }Why (the durable fix — NOT a version bump)
The bench fork deliberately keeps package.json
versionat the upstream base (2026.6.2) and carries the bench release identity in the git TAG (…-bench.3) — confirmed: even thev2026.6.8-bench.3release tag has package.json2026.6.2. So build-infoversionalone can't tell you which bench release is running. This bit the Briggs go-live and tonight's gateway cutover (--version→6.2 vs the real6.8-bench.3).I investigated bumping package.json instead and rejected it as non-durable: that field is load-bearing —
npm-shrinkwrap.json(×3 embeds),deps:shrinkwrap:check, the npm-release/postpublish/appcast tests, and the publish workflow all key off it, and the bench release process intentionally decouples it. Changing it risks the release pipeline for a cosmetic label.This instead makes a build self-report its true lineage (nearest bench tag + commits-ahead + sha) where the system reads it (build-info / health / the drift guard / debugging), with the load-bearing field untouched. The
-dirtymarker is a bonus floating-build signal (a build from an uncommitted worktree now flags itself).Anvil-ready handoff
scripts/write-build-info.ts(+resolveRelease(), +1 field). Purely additive.release: v2026.6.8-bench.3-3-gd401e877d6-dirty; package.json unchanged; existing build-info consumers see an extra field (additive, non-breaking).releasein the bench-harness drift-guard summary +openclaw --version/health output.🤖 Generated with Claude Code