Skip to content

fix(security): pin undici to patched 7.28.0 / 8.5.0 β€” green security-fast#83

Merged
LightDriverCS merged 2 commits into
mainfrom
aurelius/undici-prod-audit
Jun 23, 2026
Merged

fix(security): pin undici to patched 7.28.0 / 8.5.0 β€” green security-fast#83
LightDriverCS merged 2 commits into
mainfrom
aurelius/undici-prod-audit

Conversation

@LightDriverCS

Copy link
Copy Markdown

What

Pin undici overrides to the patched releases so the security-fast prod audit goes green repo-wide.

  • undici@7 β†’ 7.28.0, undici@8 β†’ 8.5.0 (each major bumped in place β€” no risky 7β†’8 jump).
  • Tree now resolves only the patched versions (was 7.27.2 + 8.3.0, both vulnerable).

Why

6 HIGH advisories in production deps: GHSA-vmh5-mc38-953g (SOCKS5 TLS cert-validation bypass), GHSA-38rv-x7px-6hhq / GHSA-vxpw-j846-p89q (WebSocket DoS via fragment bypass), GHSA-hm92-r4w5-c3mj (cross-origin routing via SOCKS5 pool reuse). This is the same security-fast red seen on #82 (pre-existing, not introduced there).


Anvil-ready handoff

  • Scope: pnpm-workspace.yaml (+5 lines, override + GHSA comment) and the regenerated pnpm-lock.yaml. 2 files.
  • Touched surfaces: dependency resolution only. No source/runtime code.
  • Firebase/deploy impact: none. In-major patch bumps (7.27.2β†’7.28.0, 8.3.0β†’8.5.0) β€” API-compatible.
  • Local gates: node scripts/pre-commit/pnpm-audit-prod.mjs --audit-level=high β†’ "No high or higher advisories found" (was 6 HIGH). pnpm install clean; monorepo postinstall build ran.
  • Smoke evidence: lockfile greps confirm only [email protected] + [email protected] resolved.
  • Blockers: none.
  • Follow-ups: none β€” self-contained dep-hygiene.

πŸ€– Generated with Claude Code

claude and others added 2 commits June 22, 2026 19:33
…security-fast)

CI security-fast (prod audit) was failing on 6 HIGH undici advisories:
GHSA-vmh5-mc38-953g (SOCKS5 TLS cert-validation bypass) + GHSA-38rv-x7px-6hhq /
GHSA-vxpw-j846-p89q (WebSocket DoS via fragment bypass) + GHSA-hm92-r4w5-c3mj
(cross-origin routing via SOCKS5 pool reuse). The tree resolved undici 7.27.2
(<7.28.0) and 8.3.0 (<8.5.0), both in the affected ranges.

Pin each major in place via pnpm-workspace overrides (no risky 7->8 jump):
undici@7 -> 7.28.0, undici@8 -> 8.5.0. The tree now resolves ONLY the patched
versions; node scripts/pre-commit/pnpm-audit-prod.mjs --audit-level=high reports
0 high advisories.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
@LightDriverCS

Copy link
Copy Markdown
Author

Anvil hardening pushed a follow-up fix: a061d39 aligns the direct undici package specs and generated npm shrinkwraps with the existing pnpm override/lockfile pin.

Proof run locally on the pushed head:

  • corepack pnpm install --frozen-lockfile --ignore-scripts
  • node scripts/pre-commit/pnpm-audit-prod.mjs --audit-level=high
  • corepack pnpm deps:shrinkwrap:changed:check
  • corepack pnpm test test/package-manager-config.test.ts -- --reporter=verbose
  • corepack pnpm check
  • corepack pnpm build
  • .agents/skills/autoreview/scripts/autoreview --mode local

Result: fixed-ready from Anvil; draft CI skips are expected until the orchestrator flips the PR ready-for-review.

@LightDriverCS
LightDriverCS marked this pull request as ready for review June 23, 2026 02:19
@github-actions

Copy link
Copy Markdown

Dependency Guard

This PR changes dependency-related files. Maintainers should confirm these changes are intentional.

Changed files:

  • extensions/browser/package.json
  • extensions/discord/npm-shrinkwrap.json
  • extensions/discord/package.json
  • extensions/qa-matrix/package.json
  • extensions/telegram/package.json
  • npm-shrinkwrap.json
  • package.json
  • pnpm-lock.yaml
  • pnpm-workspace.yaml

Maintainer follow-up:

  • Review whether the dependency changes are intentional.
  • Inspect resolved package deltas when lockfile, shrinkwrap, or workspace dependency policy changes are present.
  • Treat package-lock.json and npm-shrinkwrap.json diffs as security-review surfaces.
  • Run pnpm deps:changes:report -- --base-ref origin/main --markdown /tmp/dependency-changes.md --json /tmp/dependency-changes.json locally for detailed release-style evidence.

@github-actions

Copy link
Copy Markdown

Dependency graph changes noted

This PR includes dependency graph changes. The dependency guard is informational because the PR author is a repository admin or a member of @openclaw/openclaw-secops.

  • Current SHA: a061d3994c5962a41ce5e1a40d8d0d8e40ba5845
  • Trusted actor: @LightDriverCS
  • Trusted role: pull request author; repository admin

Security review is still recommended before merge when the dependency graph change is intentional.

@LightDriverCS
LightDriverCS merged commit 0ae8411 into main Jun 23, 2026
161 checks passed
@LightDriverCS
LightDriverCS deleted the aurelius/undici-prod-audit branch June 23, 2026 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants