Merged
Conversation
Owner
|
Looks good to me, but I'll wait for @FireEmerald to chime in on this :) |
FireEmerald
approved these changes
Mar 9, 2018
Contributor
FireEmerald
left a comment
FireEmerald
left a comment
There was a problem hiding this comment.
Looks good to me. After this PR was merged, there are some minor things which must be edited so the user is able to select the language as well as the translated strings do fit inside the UI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I added the spanish resources for SoundSwitch. I hope this can expand the use in Spanish language users. Best Regards