Some improvements and a feature#186
Merged
Belphemur merged 4 commits intoBelphemur:devfrom May 25, 2017
Merged
Conversation
ramon18
force-pushed
the
dev
branch
3 times, most recently
from
173ad1b to
c5f329f
Compare
FireEmerald
suggested changes
May 22, 2017
| /// <summary> | ||
| /// Show a banner notification with the given data | ||
| /// </summary> | ||
| /// <param name="data"></param> |
| Angepasste akustische Benachrichtigung: Spielt einen selbst definierten Sound ab. | ||
| Popup Benachrichtigung: Spezielle Form eines Windows Pop-ups.</value> | ||
| Popup Benachrichtigung: Spezielle Form eines Windows Pop-ups. | ||
| Banner: Verwendet eine benutzerdefinierte Form immer auf der Oberseite, kann nützlich sein, in bestimmten für In-Game-Nutzung, weil es steht über directdraw / opengl.</value> |
Contributor
There was a problem hiding this comment.
To be synced with English comment - don't use translators.
| Notif. Sonore Perso: Joue le son choisi | ||
| Notif. Toast: Popup sur le coté de l'écran dans Windows 10.</value> | ||
| Notif. Toast: Popup sur le coté de l'écran dans Windows 10. | ||
| Notif. Bannière: Utilise une forme personnalisée toujours en haut, peut être utile pour certaines utilisations dans le jeu, car elle se situe au-dessus de directdraw / opengl.</value> |
Contributor
There was a problem hiding this comment.
To be synced with English comment - don't use translators.
| Customized Sound Notification: Plays the specified sound on the switched Playback Device. | ||
| Toast Notification: Uses a special form of the windows tray pop-up version.</value> | ||
| Toast Notification: Uses a special form of the windows tray pop-up version. | ||
| Banner: Uses a custom always-on-top form, may be useful for in-game usage because it stands above directdraw/opengl.</value> |
Contributor
There was a problem hiding this comment.
" because it stands above directdraw/opengl" can be removed, the average gamer doesn't need this information.
Banner: Uses a custom always-on-top frame, useful for in-game usage.
|
|
||
| namespace SoundSwitch.Framework.NotificationManager | ||
| { | ||
| public enum NotificationCustomSoundEnum |
| { | ||
| var toastData = new BannerData | ||
| { | ||
| ImagePath = "file:///"+ApplicationPath.DefaultImagePath, |
|
|
||
| namespace SoundSwitch.Framework.Banner | ||
| { | ||
| public class BannerData |
| this.timerHide.Tick += TimerHide_Tick; | ||
| } | ||
| else | ||
| this.timerHide.Enabled = false; |
Contributor
There was a problem hiding this comment.
Codestyle...
if (a == b)
{
Fly();
} else {
Die();
}| { | ||
| BannerManager.Setup(); | ||
|
|
||
| // Available is all Windows versions |
Contributor
Author
|
I completely agree with your appointments, I just was in a rush to complete this sharing… :) I've amended my last commit, please check if I missed something. |
…h stands above any directdraw/opengl windows.
Owner
|
Firstly congratulations 🎊 for your kid 😃
This looks great, I'll try it out ASAP and will surely release a beta version with it.
Thanks @FireEmerald for the review and thank you for the PR.
Sent from BlueMail
…On May 22, 2017, 17:06, at 17:06, ramon18 ***@***.***> wrote:
I completely agree with your appointments, I just was in a rush to
complete this sharing… :)
You know, two kinds, one of them has just 3 weeks ehh!
Most of the time, I do not take the time to share my work and therefore
no one else benefits from it.
I've amended my last commit, please check if I missed something.
Thanks
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#186 (comment)
|
Owner
|
I just reviewed the code and tried it. This is magical! I'm going to set it as the new default. |
Closed
FireEmerald
added a commit
that referenced
this pull request
May 25, 2017
ToDo: French translation is missing for: (@Belphemur) - SettingsStrings.fr, notificationTooltip. - UpdateDownloadStrings, notSigned.
Owner
|
@all-contributors please add @ramon18 for code |
Contributor
|
I've put up a pull request to add @ramon18! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a few improvements and a new notification useful for gamers.
Cheers