Catch PHP7 errors implementing Throwable#833
Conversation
There was a problem hiding this comment.
Please keep the @author annotation with the original author (i.e. @nicolas-grekas IIRC)
peterjmit
force-pushed
the
catch-throwable
branch
from
12fafb6 to
b197dad
Compare
There was a problem hiding this comment.
@stof not sure if this is what you meant, perhaps just php5.3 if it works as a "minimum version"
There was a problem hiding this comment.
no need to put anything there, as 5.3 is the min version supported by Behat instead. And using it to exclude PHP 7 is wrong though. It has this behavior only because the code used on Travis actually treats PHP 7.0 as a 5.0 release (so excluding any test with a min version tag)
There was a problem hiding this comment.
@stof this test fails on php 7 locally (imo is expected to fail), so do I remove the tags or not?
|
@peterjmit you can simply amend a commit with nothing (just to change its hash) and push (with force), it should restart builds. |
peterjmit
force-pushed
the
catch-throwable
branch
from
b197dad to
894a853
Compare
|
This should be ready to merge unless there is more feedback/changes required for the PHP7 tag on the |
Catch PHP7 errors implementing Throwable
5 participants
Resolves #831
Questions:
How to correctly handle the version differences? JUnit formatter/feature might be problematicFatalThrowableErrorhas been re-appropriated from Symfony, do I need to include licensing?