refactor: convert suite tests to use fixtures#1769
refactor: convert suite tests to use fixtures#1769carlos-granados merged 2 commits intoBehat:3.xfrom
Conversation
eb251c1 to
e67692a
Compare
features/suite.feature
Outdated
| When I run "behat --config=behat-hyphens.php --format progress --suite suite-with-hyphens" | ||
| Then it should pass with: | ||
| """ | ||
| No scenarios |
There was a problem hiding this comment.
This obviously matches the original, but it doesn't necessarily prove that we have actually correctly matched the suite-with-hyphens suite name.
Particularly since we don't appear to have any coverage that it fails with an error if you specify a suite name that does not exist. We could theoretically be falling back to the first / default / all suites in this situation (we're not, but that could change in the future).
I think it might actually be viable to just rename the second suite in the existing behat-two-features.php config file to suite-with-hyphens and just reuse those examples to prove that we've selected the correct features to run. I don't think any of the other scenarios here depend on the naming of that suite.
Equally, these are quite minor/theoretical concerns so feel free to ignore & move on!
There was a problem hiding this comment.
Yeah, I see what you mean. I modified the configuration for this suite so that it actually runs some tests and then confirmed that they were run
e67692a to
b11d5f8
Compare
08fb216 to
ce4dc86
Compare
acoulton
left a comment
There was a problem hiding this comment.
Thanks @carlos-granados
No description provided.