Merged
Conversation
stof
reviewed
Nov 25, 2025
| { | ||
| $assetsId = $suite->getName(); | ||
| $pattern = $definition->getPattern(); | ||
| $cacheKey = sprintf('%s|%s|%s', $assetsId, $pattern, $language ?? ''); |
Member
There was a problem hiding this comment.
this should use $this->translator->getLocale() as default locale, not the empty string, so that an explicit locale and the usage of the default locale with the same locale share the same cache key.
Contributor
Author
There was a problem hiding this comment.
Good shout, updated
acoulton
approved these changes
Nov 25, 2025
Contributor
acoulton
left a comment
acoulton
left a comment
There was a problem hiding this comment.
LGTM, thanks @carlos-granados
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a simple memory cache so that we don't have to call the
transfunction in the translator if we already have translated the current definition, should improve performance in the cases where steps are used many timesFixes #1452