Conversation
acoulton
reviewed
May 16, 2025
| // Class names are intentionally fully qualified here to maximise clarity - particularly because a future | ||
| // PHPUnit version may reuse a class name in a different namespace. | ||
|
|
||
| if (class_exists(\PHPUnit\Util\ThrowableToStringMapper::class)) { | ||
| if (class_exists(ThrowableToStringMapper::class)) { |
Contributor
There was a problem hiding this comment.
It's probably OK to lose the fully-qualified names here - particularly now we know that people won't be able to use just the assertions from future PHPUnit versions anyway?
If so we should just remove the comment above.
Contributor
Author
There was a problem hiding this comment.
I had not realised about the comment, agree with you, removed
carlos-granados
force-pushed
the
add-rector
branch
2 times, most recently
from
130b27e to
36a68cb
Compare
carlos-granados
force-pushed
the
add-rector
branch
from
36a68cb to
d9723a1
Compare
carlos-granados
force-pushed
the
add-rector
branch
from
d9723a1 to
e19341c
Compare
Contributor
Author
|
@acoulton do you think this is now OK? I would like to merge it so that we can continue adding more Rector rules |
acoulton
approved these changes
Jun 5, 2025
Contributor
acoulton
left a comment
acoulton
left a comment
There was a problem hiding this comment.
Great, thanks @carlos-granados
carlos-granados
force-pushed
the
add-rector
branch
from
e19341c to
49f8d3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a full coding standard configuration we are ready to add the Rector tool and start using it.
We need to be careful when using it as some of the changes introduced by Rector can create BC issues so we need to evaluate all of its rules and only apply those which are safe.
This PR introduces the initial setup to use this tool and adds a couple of things:
I have separated this in two commits (tool setup and code changes) so that the code changes can be added to the blame ignore file once this PR is approved
Closes #1506