feat: implement editor url#1638
Merged
carlos-granados merged 1 commit intoBehat:masterfrom May 16, 2025
Merged
Conversation
carlos-granados
commented
May 12, 2025
Contributor
Author
|
Argh, bloody Windows dir separators, let me try to fix the tests |
29d363f to
efc9d33
Compare
Contributor
Author
|
Fixed 🎉 |
efc9d33 to
a6cf989
Compare
acoulton
reviewed
May 14, 2025
Contributor
acoulton
left a comment
There was a problem hiding this comment.
@carlos-granados this looks great and will be super helpful - just a couple of small observations
src/Behat/Testwork/PathOptions/Printer/ConfigurablePathPrinter.php
Outdated
Show resolved
Hide resolved
11075ff to
5c0b42b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the same way that PHPStan or Rector do, allow setting an editorURL template that will be used to add links to paths when printing them on the terminal.
The editorURL can be any URL that any IDE recognises to open that specific file, One example is PhpStorm which accepts URLs like this one:
phpstorm://open?file={path}&line={line}The template can use three different placeholders:
{absPath} : absolute path of the file
{relPath}: relative path of the file
{line}: line number in the file
Fixes #1596
Once this is merged I will add the corresponding documentation in Behat docs