Conversation
| $callable = $callee->getCallable(); | ||
|
|
||
| if ($callee->isAnInstanceMethod()) { | ||
| if ($callee->isAnInstanceMethod() && is_array($callable)) { |
There was a problem hiding this comment.
Need to make sure that $callable is an array before using it as an array
| parent::__construct($scopeName, $filterString, $callable, $description); | ||
|
|
||
| if ($this->isAnInstanceMethod()) { | ||
| if (is_array($callable)) { |
There was a problem hiding this comment.
Depending on the type of callable that we have we get the class name and method name using one way or another
| private $firstBackgroundEnded = false; | ||
| /** | ||
| * @var Event[] | ||
| * @var array<array{0: Event, 1: string}> |
There was a problem hiding this comment.
Wrong doc comment
| * Returns counters for different scenario result codes. | ||
| * | ||
| * @return array<TestResult::*, int> | ||
| * @return array<StepResult::*, int> |
There was a problem hiding this comment.
This includes one case that is defined in StepResult, so we use the derived class
acoulton
left a comment
acoulton
left a comment
There was a problem hiding this comment.
Looks good, just a small question/opportunity to extract some duplicate code if you'd like to do that
|
@carlos-granados it doesn't look like the branch is updated? |
|
@acoulton argh, I committed the code but forgot to push it, done |
Co-authored-by: Andrew Coulton <[email protected]>
|
@stof happy with this now? I would like to merge it to continue with this upgrade. Thanks! |
4 participants
Applies three new rules for PSalm level 6