PHP Config - suite filters#1557
Conversation
|
@acoulton @carlos-granados |
acoulton
left a comment
There was a problem hiding this comment.
LGTM.
I think I'd stick with ->withFilter() - there will often only be one, or at most a very short list, and in time we might want to add helpers like e.g. (new TagFilter())->include('ui')->exclude('php84') which would be neatest if each filter was in a separate method call.
Agreed |
carlos-granados
left a comment
There was a problem hiding this comment.
Looks good, just one comment
| ], $config->toArray()); | ||
| } | ||
|
|
||
| public function testAddingFilters(): void |
There was a problem hiding this comment.
You are missing the test to confirm that you cannot repeat a filter
d3fc8ef to
487d815
Compare
I'm wondering if we should implement
withFilters(FilterInterface ...$filters)instead.But for now, we have implemented them like this on Profile.