Update explorer.htm & CodeQL workflow#1964
Update explorer.htm & CodeQL workflow#1964valdok merged 3 commits intoBeamMW:masterfrom Maxnflaxl:master
Conversation
@dbadol update
|
This is very nice, I like it. But I have a couple of suggestions.
In previous version there's a slightly more bold margin that separates those groups, and the Height is shown only for top-level call. In this version there'e no visible margin, and the Height field is at every row. Which is more confusing IMHO. Ideally it'd be great to somehow put a bold visible separator between such groups. Also that'd be cool to "dim" other contracts invoked (i.e. maybe use smaller fonts), emphasize this specific contract being-viewed.
|
|
@valdok The only reason I removed the rowspan display for multiple contract calls is that it was making table sorting and filtering much more complicated. I thus replaced it with a simple height repetition (not ideal, but quick and simple). Now, your comment makes me think that we can still make the result much more readable just by adjusting some display parameters. I will do it. For the asset lists, the list is already automatically collapsed if there is more than 4 assets. But yes, it would be handy to have a general control somewhere. I will add it. |
|
@dbadol In addition to this we could show how much excess funds are put in/out of the current tx. In simple case where only 1 contract is invoked and no assets are emitted/burned that would match the numbers that contract locks/unlocks. Another example: in blocks history, there're many more details can be shown. Such as current cumulative values (total number of UTXOs, delta UTXOs, and etc.) The reason we didn't include all possible values in the table is the lack of screen space. |
-> @dbadol's explorer UI update
-> codeQL analysis workflow update: https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/