Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error with repeater fields default values #22

Merged
merged 1 commit into from
Jul 31, 2018

Conversation

jukra
Copy link
Contributor

@jukra jukra commented Jun 18, 2018

The default values for repeater fields did not work. After digging around, I found out that they were missing reference to the field key. This patch should fix the issue. At least for me now the default values work with repeaters as well. Please test further!

The default values for repeater fields did not work. After digging around, I found out that they were missing reference to the field key. This patch should fix the issue. At least for me now the default values work with repeaters as well. Please test further!
@MaximeCulea
Copy link
Contributor

Hello @jukra !

Thx for the submission. I'll have a look soon, I was on holidays.

@MaximeCulea MaximeCulea self-assigned this Jun 27, 2018
@tlehtimaki
Copy link

Took this pull request to use. Works nicely for me too.

@MaximeCulea MaximeCulea merged commit 7b14c10 into BeAPI:master Jul 31, 2018
@MaximeCulea
Copy link
Contributor

MaximeCulea commented Jul 31, 2018

Hi @jukra, thx so much it's working smoothly !
EDIT: I've been editing a little bit the code for basic refactoring and also to make it versatile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants