Fix bug where options pages with a custom post_id weren't getting matched to their translated version#21
Merged
MaximeCulea merged 4 commits intoBeAPI:masterfrom Nov 13, 2018
Merged
Conversation
…ched to their translated version
Contributor
|
Hello @legroomdwyer, thx for the submission, I'll have a look soon back to my holidays. |
Contributor
|
Hello @legroomdwyer, Thank you for contacting us and for the PR. It looks great, I am doing some tests before merging. Thank you |
Contributor
|
Working with custom and default option id. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an options created with this:
but calling
get_field('footer_columns', 'appearance')wouldn't match to the translated version, and in wp-admin the content was the same regardless of what Polylang language was selected.Main changes:
menu_slug's previously)get_field()when fetching the default "All languages" version so that repeaters and stuff are parsed properly