Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with using repeater / all languages #41

Closed
foxalliance opened this issue Feb 26, 2019 · 14 comments
Closed

Problem with using repeater / all languages #41

foxalliance opened this issue Feb 26, 2019 · 14 comments
Assignees

Comments

@foxalliance
Copy link

Version information

  • Plugin version :
  • PHP : 7.3.1
  • WordPress : 5.0.3
  • ACF version : 5.7.12 pro
  • Polylang version : 2.5 pro

Hi, I also have a problem with using repeat, it turns out that the plugin takes into account the number of lines added to the repeater and, depending on the number of fields fills all languages with empty values of other fields, here is a video problem : https://cloud.mail.ru/public/J3c7/cQi8FFPxu how to fix???

@MaximeCulea MaximeCulea self-assigned this Feb 26, 2019
@MaximeCulea
Copy link
Contributor

Hi @foxalliance,
Thank you for submitting an issue.

I have been looking your video and seems working good.
When you switch from Russian language which is empty repeater, this is the "all languages values" which is used : first row filled and second one with some integer. If you change theses, it should be good for your empty values for Russian.

Can you please try this ? Thank you.

@foxalliance
Copy link
Author

foxalliance commented Feb 26, 2019

https://cloud.mail.ru/public/LCvW/drCgazuVZ
Fields are not populated until I add an empty field in a specific language

@jjfer
Copy link

jjfer commented Mar 5, 2019

I'm having the same problem with repeater field. To get values from "All languages", I have to add empty rows for all the other languages. It's not very handy because I have over 100 rows in repeater and 8 languages.

Is there any possibility that you could fix the plugin so that if the repeater field is empty in some language, then the "All languages" list is shown?

@Cweet
Copy link

Cweet commented Mar 6, 2019

I have the same problem. None of my "All languages" repeater fields are shown.

@MaximeCulea
Copy link
Contributor

To sum up, the issue is that when using a repeater, the "all languages" default value is not retrieved if the language repeater is not set ? You have to set an empty repeater to trick this ?

Thank you for the feedback here @foxalliance @jjfer @Candielope.

@MaximeCulea MaximeCulea pinned this issue Mar 20, 2019
@foxalliance
Copy link
Author

Yes

@foxalliance
Copy link
Author

Is the solution real or not? The developer for some reason is silent and only asks questions...

@MaximeCulea
Copy link
Contributor

I really don’t know. Since I haven’t reach it yet. It’s something complicated that don’t only needs 1-2 hours of work.
So please be patient, I am really busy theses days ..

@bhuisman1992
Copy link

Great to hear!
I'm also waiting for a solution! :)

@MaximeCulea MaximeCulea changed the title Problem with using repeat Problem with using repeater / all languages Apr 11, 2019
@MaximeCulea
Copy link
Contributor

I think I have reach a solution, in this configuration :

  • empty "EN" repeater
  • populated "FR" repeater
  • overpopulated "All languages" repeater

When in front on a french page, shows french repeater, when on the english page, shows default one. Which seems fixing this issue. See the video.

ex  test - Edited

Also note that I can't merge repeaters. For exemple, If using 1 repeater in english and other 3 by default. It will switch automatically to the default since the localized one is empty.

Could you please @foxalliance @jjfer @Candielope @bhuisman1992 check with this version if it also fix your issue ?
Thank you

@MaximeCulea MaximeCulea unpinned this issue Apr 11, 2019
@MaximeCulea MaximeCulea pinned this issue Apr 11, 2019
@foxalliance
Copy link
Author

foxalliance commented Apr 11, 2019

Checked at myself, the correction works as it is necessary! Thank you !

@MaximeCulea
Copy link
Contributor

Ok thanks, need to wait more feedback from others, then make the package.

@herewithme
Copy link
Member

@foxalliance @Candielope Can you test the development version (https://github.com/BeAPI/acf-options-for-polylang/tree/ticket/41) ?

We made additional changes. Thanks

MaximeCulea added a commit that referenced this issue May 7, 2019
@herewithme
Copy link
Member

Release 1.1.7 :)

@herewithme herewithme unpinned this issue May 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants