Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never inited on frontend #15

Closed
oxyc opened this issue May 8, 2018 · 7 comments
Closed

Never inited on frontend #15

oxyc opened this issue May 8, 2018 · 7 comments
Assignees
@MaximeCulea
Labels
Bug

Comments

@oxyc
Copy link
Contributor

oxyc commented May 8, 2018

Version information

  • Plugin version : Master
  • PHP : 7.1
  • WordPress : 4.9.4
  • ACF version : 5.6.10
  • Polylang version : 2.3.4

Steps to reproduce

  1. Translate an option

What was expected

Display the translated value

What happened instead

All language value is displayed.

Reason

Requirements never actually checks requirements on frontend as it's only hooked into admin_init

https://github.com/BeAPI/acf-options-for-polylang/blob/master/classes/requirements.php#L13
@MaximeCulea MaximeCulea self-assigned this May 9, 2018
@MaximeCulea MaximeCulea added the Bug label May 9, 2018
@MaximeCulea
Copy link
Contributor

Hi @oxyc,

Thank you for the report =D

It seems you are right concerning the frontend loading, however I need to fix and test this in a separated branch to ensure to correct this issue and not break something else.
I will let you soon know about solving this.

MaximeCulea added a commit that referenced this issue May 9, 2018
@MaximeCulea
#15 : check for requirements on plugins loaded which trigger on front…
a340ff2 
… and admin.
MaximeCulea added a commit that referenced this issue May 9, 2018
@MaximeCulea
#15 : no more load with hook, use class instead
0afa170
@MaximeCulea
Copy link
Contributor

@oxyc could you please check with the issue-15 version ? plz

@MaximeCulea
Copy link
Contributor

@oxyc any news ? thx

@oxyc
Copy link
Contributor Author

oxyc commented May 13, 2018

i'll try it out during next week! thanks for a prompt fix!

@MaximeCulea
Copy link
Contributor

Other people have the same issue and it's blocking them, so as it seems that this patch fix it, I am closing this issue since I have already released it.

Feel free to reopen it if it's not your case, thank you.

@oxyc
Copy link
Contributor Author

oxyc commented May 14, 2018

This introduced a bug with an undefined constant: BEA_CPT_AGENT_PLUGIN_DIRNAME.

@MaximeCulea
Copy link
Contributor

My bad, a quick copy/paste from an other plugin which as no other effect than this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaximeCulea MaximeCulea

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oxyc @MaximeCulea