Repository navigation
Commit 0828992
fix(desktop): emit singular "mention" feed category to match frontend contract
Native `get_feed` emitted feed items with `category: "mentions"` (plural),
but the `FeedItemCategory` union (shared/api/types.ts) and every frontend
comparison (feed.ts, inbox.ts) use the singular `"mention"` — as does the
e2e bridge. The mismatch made native mention items fall through to the
needs-action fallback, so a mention toasted as "Needs Action in #channel"
instead of "X mentioned you in #channel" (observed live in block#2105), and
inbox labeling/priority misclassified them.
Emit the singular `"mention"` to match the declared contract. The `types`
request-filter keyword ("mentions") is a separate API surface and is left
unchanged. Adds a regression test asserting the emitted category.
Refs block#2106
Signed-off-by: Bartok9 <[email protected]>
(cherry picked from commit f372981)
Signed-off-by: Bartok9 <[email protected]>1 parent a567dfc commit 0828992
2 files changed
Lines changed: 24 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
135 | 135 | | |
136 | 136 | | |
137 | 137 | | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
138 | 145 | | |
139 | 146 | | |
140 | 147 | | |
141 | | - | |
| 148 | + | |
142 | 149 | | |
143 | 150 | | |
144 | 151 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
224 | 224 | | |
225 | 225 | | |
226 | 226 | | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
0 commit comments