fix: #564 resolves issue with element.replace on non-string elements#565
Merged
vejja merged 1 commit intoBaroshem:chore/2.1.3from Nov 22, 2024
Merged
fix: #564 resolves issue with element.replace on non-string elements#565vejja merged 1 commit intoBaroshem:chore/2.1.3from
vejja merged 1 commit intoBaroshem:chore/2.1.3from
Conversation
|
@lawren is attempting to deploy a commit to the Baroshem's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
@lawren would you be able to verify if it works now on your side ? {
"devDependencies": {
"nuxt-security": "https://pkg.pr.new/Baroshem/[email protected]"
}
} |
Contributor
Author
|
@vejja verified! Looks good on my end. Really appreciate the quick response on this! FYI, I just realized the same issue appears to be happening with SRI enabled as well. I am assuming it's the same issue, but just in another nitro plugin. Will try to look into it later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
This PR fixes an issue in the
cspSsrNonce.tsfile whereelement.replacewas called on non-string elements in thehtml[section]array during nonce injection. This caused aTypeError: element.replace is not a functionin SSR mode when third-party libraries, such as PrimeVue, injected non-string elements.The change introduces a type check to skip non-string elements, ensuring the rendering process doesn’t break and nonce attributes are properly applied to valid elements.
Why is this change required?
This resolves a crash in applications using Nuxt Security with SSR and libraries like PrimeVue.
Resolves: #564
Checklist: