Skip to content

fix(core): do not remove loggers in dev mode#561

Merged
vejja merged 2 commits intomainfrom
vejja/issue559
Nov 19, 2024
Merged

fix(core): do not remove loggers in dev mode#561
vejja merged 2 commits intomainfrom
vejja/issue559

Conversation

@vejja
Copy link
Copy Markdown
Collaborator

@vejja vejja commented Nov 19, 2024

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #559

This PR ensures that console.log statements are not removed in dev mode, as this is the expected standard beahviour.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 1:58pm

@vejja vejja self-assigned this Nov 19, 2024
@vejja vejja marked this pull request as ready for review November 19, 2024 13:22
@vejja vejja requested a review from Baroshem November 19, 2024 13:22
@vejja vejja changed the title do not remove loggers in dev mode fix(core): do not remove loggers in dev mode Nov 19, 2024
@vejja vejja merged commit 5769795 into main Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Baroshem Baroshem Awaiting requested review from Baroshem

Assignees

@vejja vejja

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Loggers are removed in development mode too

1 participant

@vejja