Repository navigation
Commit 9c4e4e3
committed
Schematic sheets: read each row once
Hier.read.go passed the rest of the list to both arms of Bool.pick, and
Bool.pick takes its arguments evaluated, so every line read the rest twice:
2^n row reads for n sheets. The web viewer reads the project's sheets on
every render (View.sheets, twice), so with a 19-sheet schematic each render
of the page spent seconds in it, and the Schematic tab took most of a
minute to show. Each row is now read once (Hier.read.keep takes the rest
already read), and View.sheets reads the sheets once per render. The phones
and the window read sheets through the same Hier.read.
hier_test: forty sheets read back (41 rows) -- killed at 60 s before, the
whole test now runs in 0.7 s.1 parent 8a3b63a commit 9c4e4e3
3 files changed
Lines changed: 27 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
294 | 294 | | |
295 | 295 | | |
296 | 296 | | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
297 | 306 | | |
298 | 307 | | |
299 | 308 | | |
300 | 309 | | |
301 | 310 | | |
302 | | - | |
| 311 | + | |
303 | 312 | | |
304 | 313 | | |
305 | 314 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1425 | 1425 | | |
1426 | 1426 | | |
1427 | 1427 | | |
| 1428 | + | |
| 1429 | + | |
| 1430 | + | |
| 1431 | + | |
| 1432 | + | |
1428 | 1433 | | |
1429 | | - | |
1430 | | - | |
| 1434 | + | |
1431 | 1435 | | |
1432 | 1436 | | |
1433 | 1437 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
36 | 44 | | |
37 | 45 | | |
38 | 46 | | |
39 | 47 | | |
40 | 48 | | |
41 | 49 | | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
42 | 53 | | |
43 | 54 | | |
44 | 55 | | |
| |||
0 commit comments