Added support to use NCCL with python3 and fixed nvml.dll related error under windows#5400
Added support to use NCCL with python3 and fixed nvml.dll related error under windows#5400willyd wants to merge 2 commits intoBVLC:windowsfrom
Conversation
|
Closing as presumed fixed until hearing otherwise. |
|
@shelhamer I will keep this one open since I would like that fix to go in on windows. There are two fixes in this PR:
|
|
I tested the first commit about uid and it works, can you remove the second commit so that we can merge? |
|
@cypof I wrote the code in a rush so let me clean it up (I think I can come up with less changes) and then I will resubmit the first commit to master. |
|
@cypof @shelhamer I could simplify the first commit if we use a relatively recent version of boost. According to the docs we require 1.55 but according to the CMake build we require 1.46, I assume that the docs is more up to date than the CMake build. Am I correct? I am asking since 1.53 handles the conversion from python strings and bytes to C++ std::string automatically. If we can assume this we only have to convert manually from C++ to python. |
|
Part of this was merge in #5527. |
WIP. This may be of interest for the master branch since the python 3 error is not OS specific. I may split this PR in two.