Skip to content

replace snprintf with a C++98 equivalent#3361

Merged
ronghanghu merged 1 commit intoBVLC:masterfrom
BonsaiAI:avoid-snprintf
Nov 27, 2015
Merged

replace snprintf with a C++98 equivalent#3361
ronghanghu merged 1 commit intoBVLC:masterfrom
BonsaiAI:avoid-snprintf

Conversation

@eelstork
Copy link
Copy Markdown
Contributor

@eelstork eelstork commented Nov 20, 2015

snprintf is not consistently available on Windows.
Although patchy support is possible (search snprintf in suggested reference), I find that snprintf may be advantageously replaced by a solution which doesn't involve defining arbitrarily sized buffers and converting between C and C++ strings.
As I understand that C++ streams are not very popular and the main use of snprintf in Caffe is producing numbered batches, I suggest the introduction of a utility function (format_int).

@ronghanghu
Copy link
Copy Markdown
Member

ronghanghu commented Nov 20, 2015

IMHO snprintf is a standard io function in C/C++, available in <stdio.h> / <cstdio> and is (or at least should be) cross-platform. http://www.cplusplus.com/reference/cstdio/snprintf/

Note: Microsoft has finally implemented snprintf in Visual Studio 2015.

@eelstork
Copy link
Copy Markdown
Contributor Author

eelstork commented Nov 20, 2015

@ronghanghu specifically, snprintf is available in C99 and C++11, not C++98 (for proof, replacing <stdio.h> with <cstdio> will break C.I. builds).
VS2015 is a bit too new for most Windows build workers.
This is a compatibility issue.

@eelstork
Copy link
Copy Markdown
Contributor Author

eelstork commented Nov 26, 2015

Opinions on this PR?

@ronghanghu
Copy link
Copy Markdown
Member

ronghanghu commented Nov 26, 2015

This all looks good to me. I'll try to review during the Thanksgiving (got a bit overwhelmed myself these days since it is near the end of the semester).

@ronghanghu ronghanghu self-assigned this Nov 26, 2015
@eelstork
Copy link
Copy Markdown
Contributor Author

eelstork commented Nov 26, 2015

@ronghanghu thanks! Don't forget to relax during holidays.

ronghanghu added a commit that referenced this pull request Nov 27, 2015
@ronghanghu
Merge pull request #3361 from BonsaiAI/avoid-snprintf
c7ee261 
replace snprintf with a C++98 equivalent
@ronghanghu ronghanghu merged commit c7ee261 into BVLC:master Nov 27, 2015
@ronghanghu
Copy link
Copy Markdown
Member

ronghanghu commented Nov 27, 2015

Thanks @eelstork !

@eelstork eelstork mentioned this pull request Dec 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ronghanghu ronghanghu

Labels

compatibility ready for review style

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eelstork @ronghanghu @longjon