Skip to content

Make the two separate build systems clearer in the documentation#2651

Closed
keir wants to merge 1 commit intoBVLC:masterfrom
keir:master
Closed

Make the two separate build systems clearer in the documentation#2651
keir wants to merge 1 commit intoBVLC:masterfrom
keir:master

Conversation

@keir
Copy link
Copy Markdown
Contributor

@keir keir commented Jun 26, 2015

No description provided.

@bhack
Copy link
Copy Markdown
Contributor

bhack commented Jun 26, 2015

Or probably remove Makefile. Two build system are quite impossible to be maintained in sync. Also Travis builds are not aligned between Make and Cmake.

@keir
Copy link
Copy Markdown
Contributor Author

keir commented Jun 26, 2015

I had some trouble getting Caffe built since the installation instructions were not easily scannable, hence this patch. Is the documentation out of date with practice (e.g. is CMake the new official system)? I suggest merging this as-is since it's a strict improvement. If the Make system is deprecated, then that is a separate change.

@bhack
Copy link
Copy Markdown
Contributor

bhack commented Jun 26, 2015

Yes it is ok. But it is not really clear how this two build systems are in sync.

@keir
Copy link
Copy Markdown
Contributor Author

keir commented Jun 26, 2015

OK. So can you merge it? Or should I abandon this?

@bhack
Copy link
Copy Markdown
Contributor

bhack commented Jun 26, 2015

@keir All core devs are MIA. We need to wait some celestial sign.

@keir
Copy link
Copy Markdown
Contributor Author

keir commented Jun 26, 2015

Ah, I didn't realize you were not a core dev :) They may be finishing off their ICCV reviews.

@jeffdonahue
Copy link
Copy Markdown
Contributor

Thanks for improving these docs @keir -- merged in 6d11108 with a typo fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants