Remove scikit-learn dependency#2192
Merged
shelhamer merged 2 commits intoBVLC:masterfrom Mar 27, 2015
Merged
Conversation
Member
|
|
Contributor
Author
Ah, I didn't see that. Strange that it didn't show up in a repository-wide search. |
Contributor
Author
|
I added a comment in the example, is that sufficient? |
Member
|
Yeah, this seems fine. @longjon how do you feel about not forcing dependencies needed in an example? |
Contributor
|
@shelhamer I'm fine with not forcing dependencies for examples if clearly noted. |
shelhamer
added a commit
that referenced
this pull request
Mar 27, 2015
Remove scikit-learn dependency -- the need is noted in the relevant example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell,
scikit-learnis never used. I get no results when I search for either "scikit-learn" or "sklearn." If it is really not used, can we remove it from requirements.txt? This is the only pip dependency which doesn't have a debian installer in Ubuntu 14.04 (besidesPillow>=2.7.0, which I'll address separately).FWIW, all tests still pass without
scikit-learninstalled, but I don't trust the python test coverage much.