Added Pillow to requirements.txt#2010
Merged
shelhamer merged 1 commit intoBVLC:masterfrom Mar 7, 2015
Merged
Conversation
shelhamer
added a commit
that referenced
this pull request
Mar 7, 2015
[pycaffe] Add Pillow to requirements.txt
Member
|
Thanks! |
Contributor
|
Is 2.7.0 really required? 2.3.0 comes with Ubuntu 14.04 ( @danielhamngren, was there a reason you chose 2.7.0? Or was that simply the default version that came when you did a |
Contributor
Author
|
Hi, I used 2.7.0, as you guessed, because that was the default one at the time when doing a 'pip install pillow'. If everything works with 2.3.0, then I agree 2.7.0 is too stringent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will prevent the caffe python package break due to lack of supported image formats. I don't know which image formats would be supported without Pillow (or PIL) but now at least JPEG and PNG are supported.
See #1997
Most people in this field probably already have Pillow or PIL and wouldn't notice about this, but it'll make installing pycaffe a little bit easier on a fresh OS install.