Conversation
This commit addresses the failures in the GitHub Action workflow when attempting to build .deb packages for the 'oss' channel. Changes: 1. Update `script/linux/install_build_deps` to include `fakeroot`, which is required for `dpkg-deb -b`. 2. Modify `script/linux/bundle_deb` to conditionally skip repository configuration for the 'oss' channel. This prevents errors when trying to append upstream-specific repository templates that are not applicable or present for the open-source fork. Co-authored-by: BLumia <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of changes: - Added `libdbus-1-dev` and `fakeroot` to `script/linux/install_build_deps`. `libdbus-1-dev` was missing, causing `libdbus-sys` to fail compilation in CI. `fakeroot` is needed for `.deb` packaging. - Modified `script/linux/bundle_deb` to conditionally skip repository configuration when building for the 'oss' channel, avoiding errors with missing or inapplicable upstream templates. - Updated `openwarp_release.yml` to trigger on pull requests and added a condition to skip the final release publishing step for PR builds. Co-authored-by: BLumia <[email protected]>
- Reverted changes in `script/linux/bundle_deb` and `script/linux/install_build_deps`. - Moved `libdbus-1-dev` and `fakeroot` installation directly to the `.github/workflows/openwarp_release.yml` workflow. - This addresses the review feedback by avoiding modifications to shared scripts while still fixing the CI build failures. Co-authored-by: BLumia <[email protected]>
1 participant
The .deb build in CI was failing due to missing
fakerootdependency and attempts to use upstream-specific repository templates for the OSS channel. I've addedfakerootto the build dependencies and made the repository configuration inbundle_debconditional on the release channel.PR created automatically by Jules for task 481273996731769133 started by @BLumia