Skip to content

CI: Windows MSVC C++17#6448

Open
ax3l wants to merge 3 commits intoBLAST-WarpX:developmentfrom
ax3l:ci-win-cxx17
Open

CI: Windows MSVC C++17#6448
ax3l wants to merge 3 commits intoBLAST-WarpX:developmentfrom
ax3l:ci-win-cxx17

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Dec 9, 2025

Try to re-enable MSVC compilation in CI.

Use C++17 for now (see #6406)

Disabled since #5230

  • merge AMReX upstream patches before merging

@ax3l ax3l requested a review from EZoni December 9, 2025 18:14
@ax3l ax3l added the component: tests Tests and CI label Dec 9, 2025
@ax3l ax3l requested a review from WeiqunZhang December 9, 2025 19:14
WeiqunZhang pushed a commit to AMReX-Codes/amrex that referenced this pull request Dec 9, 2025
## Summary

Include explicitly used MF types in MLMG headers.

## Additional background

-
#4806 (comment)
- BLAST-WarpX/warpx#6448
@ax3l ax3l changed the title CI: Windows MSVC C++17 [WIP] CI: Windows MSVC C++17 Dec 9, 2025
@WeiqunZhang
Copy link
Copy Markdown
Member

I tested this amrex PR on my branch. It seems to work. AMReX-Codes/amrex#4842

@ax3l ax3l changed the title [WIP] CI: Windows MSVC C++17 CI: Windows MSVC C++17 Jan 6, 2026
@ax3l ax3l added the machine / system Machine or system-specific issue label Jan 6, 2026
Comment thread .github/workflows/windows.yml Outdated
@EZoni EZoni self-requested a review January 21, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component: tests Tests and CI machine / system Machine or system-specific issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants