Skip to content

Polymorphic PC#1210

Merged
ax3l merged 2 commits intoBLAST-ImpactX:developmentfrom
ax3l:topic-polymorphic-pc
Feb 26, 2026
Merged

Polymorphic PC#1210
ax3l merged 2 commits intoBLAST-ImpactX:developmentfrom
ax3l:topic-polymorphic-pc

Conversation

@ax3l
Copy link
Copy Markdown
Member

@ax3l ax3l commented Nov 10, 2025

  • replace all templates
  • setArena, update define() calls, etc.
  • rebase/merge after 25.11 release
  • test on GPU at runtime

@ax3l ax3l requested a review from atmyers November 10, 2025 05:42
@ax3l ax3l changed the title Polymorphic PC [WIP] Polymorphic PC Nov 13, 2025
ax3l added a commit to AMReX-Codes/pyamrex that referenced this pull request Feb 14, 2026
Using the `amrex::PolymorphicArenaAllocator`. Close #425

### To Do

- [x] specialize PC with `amrex::PolymorphicArenaAllocator`
- [x] update tests / add a Python test based on the C++ AMReX example
- [x] run tests on GPU
- [x] update WarpX: BLAST-WarpX/warpx#6374
- [x] update ImpactX: BLAST-ImpactX/impactx#1210
- [x] specialize/build less PC combinations for BLAST codes (only
polymorphic) -- save build time in pyAMReX

### Later On

- [x] add a C++ example to AMReX tests
AMReX-Codes/amrex#4380 @atmyers
- [ ] update Sphinx docs (remove other specialized types instead...
maybe wait for full-RT PC...)
@ax3l ax3l force-pushed the topic-polymorphic-pc branch from 08e171a to dc2ec08 Compare February 23, 2026 21:35
@ax3l ax3l changed the title [WIP] Polymorphic PC Polymorphic PC Feb 23, 2026
@ax3l ax3l force-pushed the topic-polymorphic-pc branch 3 times, most recently from f3e93c5 to 97275e5 Compare February 23, 2026 21:38
@ax3l ax3l force-pushed the topic-polymorphic-pc branch from 97275e5 to 5e2010c Compare February 24, 2026 04:20
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Feb 24, 2026

Merging this PR will not alter performance

✅ 37 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing ax3l:topic-polymorphic-pc (5e2010c) with development (f2d53f3)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@ax3l ax3l merged commit bfdfa9f into BLAST-ImpactX:development Feb 26, 2026
18 checks passed
@ax3l ax3l deleted the topic-polymorphic-pc branch February 26, 2026 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants