Skip to content

Deprecate ROPC flow#998

Merged
Avery-Dunn merged 2 commits intoAzureAD:devfrom
Ugonnaak1:akaliugonna/deprecateROPC
Oct 10, 2025
Merged

Deprecate ROPC flow#998
Avery-Dunn merged 2 commits intoAzureAD:devfrom
Ugonnaak1:akaliugonna/deprecateROPC

Conversation

@Ugonnaak1
Copy link
Copy Markdown
Contributor

@Ugonnaak1 Ugonnaak1 commented Oct 9, 2025

@Ugonnaak1 Ugonnaak1 requested a review from a team as a code owner October 9, 2025 20:01
* Acquires tokens from the authority configured in the application via Username/Password authentication.
* Acquires tokens from the authority configured in the application via Username/Password authentication.<br>
* <p><b>Deprecated:</b> This API has been deprecated and will be removed in a future release. Use a more secure flow instead.<br>
* See <a href="https://aka.ms/msalnet-ropc-migration">https://aka.ms/msalnet-ropc-migration</a> for migration guidance.
Copy link
Copy Markdown
Contributor

@Avery-Dunn Avery-Dunn Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make sense to put this comment/annotation over the UserNamePasswordParameters class also.

This is the only public API that uses it so we may as well get rid of that whole class in the future.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I've added the deprecation comment here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, is there a reason the CI pipeline tests aren't running?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few years back we realized it could be a risk to let every contributor inject code into our pipelines, so most of our repos don't trigger the pipelines when the PR is based on a fork.

Normally I'd run them manually before merging, but since these are just comments there shouldn't be any problem.

@Ugonnaak1 Ugonnaak1 requested a review from Avery-Dunn October 10, 2025 17:21
@Avery-Dunn Avery-Dunn merged commit c75065b into AzureAD:dev Oct 10, 2025
1 check passed
Copilot AI mentioned this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants