Conversation
| * Acquires tokens from the authority configured in the application via Username/Password authentication. | ||
| * Acquires tokens from the authority configured in the application via Username/Password authentication.<br> | ||
| * <p><b>Deprecated:</b> This API has been deprecated and will be removed in a future release. Use a more secure flow instead.<br> | ||
| * See <a href="https://aka.ms/msalnet-ropc-migration">https://aka.ms/msalnet-ropc-migration</a> for migration guidance. |
There was a problem hiding this comment.
It would make sense to put this comment/annotation over the UserNamePasswordParameters class also.
This is the only public API that uses it so we may as well get rid of that whole class in the future.
There was a problem hiding this comment.
That makes sense. I've added the deprecation comment here
There was a problem hiding this comment.
Also, is there a reason the CI pipeline tests aren't running?
There was a problem hiding this comment.
A few years back we realized it could be a risk to let every contributor inject code into our pipelines, so most of our repos don't trigger the pipelines when the PR is based on a fork.
Normally I'd run them manually before merging, but since these are just comments there shouldn't be any problem.
AB#3397688