Merged
Conversation
bgavrilMS
approved these changes
Sep 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes various small issues found during an analysis by SonarQube. It doesn't fix all of the issues identified by SonarQube, but these are all issues that should have zero risk of changing any actual behavior of the library.
A few dozen files received changes, but the majority of them just had unused imports removed. As for the other classes, they had equally minor changes:
AadInstanceDiscoveryProvider: removed unused parameter, and replace a String with an existing constantAcquireTokenByAppProviderSupplier: avoid creating unnecessary temp String when logging a Long valueAcquireTokenByManagedIdentitySupplier,ClientCertificate: remove reference to an exception that is never actually thrown in a methodAuthority,AuthorizationRequestUrlParameters,ClientCredentialFactory,TelemetryManager: use.isEmpty()to check if something is empty instead of... == 0AuthorizationResponseHandler: reference a standard enum rather than use a StringManagedIdentityApplication: deprecate a builder API which was not actually doing anythingManagedIdentityRequest: remove unnecessarytoString()callManagedIdentityClient,ManagedIdentityResponse: remove unused loggerPublicClientApplication: refactor unnecessarily nested if statements to be on one line