Use more common "static final" instead of "final static"#993
Merged
Avery-Dunn merged 2 commits intodevfrom Sep 16, 2025
Merged
Conversation
gladjohn
reviewed
Sep 13, 2025
msal4j-sdk/src/integrationtest/java/com.microsoft.aad.msal4j/AcquireTokenInteractiveIT.java
Outdated
Show resolved
Hide resolved
gladjohn
approved these changes
Sep 13, 2025
…cquireTokenInteractiveIT.java Co-authored-by: Gladwin Johnson <[email protected]>
bgavrilMS
approved these changes
Sep 16, 2025
neha-bhargava
approved these changes
Sep 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain Java conventions suggest "static final" as the ordering of keywords when making a constant, rather than "final static".
SonarQube considered this a minor issue, and as this PR shows it was quite common in the codebase.
Although this PR affects a lot of files it's the exact same change in each one, and should not affect the behavior of the library in any way.