Add/improve javadocs for interface classes#973
Merged
Avery-Dunn merged 1 commit intodevfrom Jul 21, 2025
Merged
Conversation
bgavrilMS
reviewed
Jul 15, 2025
| * Various parameter classes in the library implement this interface to provide a consistent way to | ||
| * configure token requests. | ||
| */ | ||
| interface IAcquireTokenParameters { |
Member
There was a problem hiding this comment.
nit: strange that you went with interface for this. new field -> broken interface.
Contributor
Author
There was a problem hiding this comment.
It was before my time here so I don't know why it's an interface.
But it's not public, so if we did add something it wouldn't be a breaking change for customers since they could only see our implementations anyway (it would be the same as adding a new public API to any class).
bgavrilMS
approved these changes
Jul 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Begins the work described in #971
This PR fills documentation gaps and improves existing documentation to all interfaces in the library. The changes exclusively affect Javadoc comments, so there are no changes to the actual behavior of any API.
This PR is also a trial run of the new agent feature in IntelliJ's Copilot plugin: