Skip to content

Suppress CodeQL issues#966

Merged
Avery-Dunn merged 1 commit intodevfrom
avdunn/codeql-suppressions
Jun 5, 2025
Merged

Suppress CodeQL issues#966
Avery-Dunn merged 1 commit intodevfrom
avdunn/codeql-suppressions

Conversation

@Avery-Dunn
Copy link
Copy Markdown
Contributor

Recent CodeQL scans found two issues:

  • SM05136: Use of a weak, unapproved or risky cryptographic algorithm, hash or signature
    • This is due to the use of SHA-1 hashing in ADFS scenarios
    • All other scenarios have moved to SHA-256, however ADFS still requires SHA-1 and therefore we must keep this code in place until ADFS is updated.
  • SM03767: Unsafe hostname verification
    • This is due to disabling hostname verification of a specific certificate in Service Fabric scenarios
    • We expect the connection to work against a specific certificate in a Service Fabric environment only, so it's safe to disable the hostname verification for this scenario

@Avery-Dunn Avery-Dunn requested a review from a team as a code owner June 5, 2025 17:33
@Avery-Dunn Avery-Dunn merged commit 04130d4 into dev Jun 5, 2025
5 checks passed
@Avery-Dunn Avery-Dunn deleted the avdunn/codeql-suppressions branch September 15, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants