Support multiple date formats in managed identity flows#956
Merged
Avery-Dunn merged 2 commits intodevfrom May 20, 2025
Merged
Conversation
| class DateTimeTests { | ||
|
|
||
| @Test | ||
| void parseUnixTimestampInSeconds() { |
Contributor
There was a problem hiding this comment.
Nice tests, does cover all the cases.
neha-bhargava
approved these changes
May 15, 2025
gladjohn
approved these changes
May 20, 2025
bgavrilMS
approved these changes
May 20, 2025
gladjohn
reviewed
May 20, 2025
|
|
||
|
|
||
| @ParameterizedTest | ||
| @ValueSource(strings = { |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #873, similar to the issue and fix in MSAL .NET: AzureAD/microsoft-authentication-library-for-dotnet#4964
The expires_on value returned in a response during managed identity flows could be a simple Unix epoch timestamp or an ISO 8601 formatted date, though the current implementation only handles the timestamp.
This PR adds support for the missing date formats, clearer exception message, and tests for the new parsing method as well a mocked MI flow.