Merged
Conversation
sangonzal
approved these changes
Jul 25, 2019
Contributor
sangonzal
left a comment
sangonzal
left a comment
There was a problem hiding this comment.
Looks good to me. Tested on my machine and it works. We can probably go ahead and make the same updates to https://github.com/Azure-Samples/ms-identity-java-webapp
| String redirectUri; | ||
| String secretKey; | ||
|
|
||
| String oboClientId; |
Contributor
There was a problem hiding this comment.
Can probably get rid of these for now, since they are not being used.
| import org.json.JSONException; | ||
| import org.json.JSONObject; | ||
|
|
||
|
|
| } | ||
|
|
||
|
|
||
|
|
| aad.clientId= | ||
| aad.authority= | ||
| aad.secretKey= | ||
| aad.redirectUri= |
Contributor
There was a problem hiding this comment.
As discussed, might make sense to include default redirectUri
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.