Conversation
Contributor
SomkaPe
commented
Jun 22, 2019
SomkaPe
commented
- silent flow for client credential grant
- use tenant id from request authority if id token not returned
- use AutoCloseable for cache Aspect application
sangonzal
approved these changes
Jun 24, 2019
| .get(); | ||
|
|
||
| Assert.assertNotNull(result); | ||
| Assert.assertNotNull(result.accessToken()); |
Contributor
There was a problem hiding this comment.
Might also be worth writing a test that has multiple tokens in cache for same clientId and tenant but different scopes and check that the right token is returned.
Contributor
Author
There was a problem hiding this comment.
good point - extended to few scopes and found serious bug
henrik-me
reviewed
Jun 25, 2019
| TokenRequest(Authority requestAuthority, MsalRequest msalRequest, ServiceBundle serviceBundle) | ||
| throws MalformedURLException { | ||
| this.requestAuthority = requestAuthority; | ||
| this.tokenEndpointUrl = new URL(requestAuthority.tokenEndpoint()); |
Contributor
There was a problem hiding this comment.
Do you need both here, Perhaps authority.tokenEndpointUrl could do this instead?
Contributor
Author
There was a problem hiding this comment.
good point, changed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.