Skip to content

exposing rt grant flow as public api#48

Merged
SomkaPe merged 2 commits intodevfrom
somkape/enableRtGrant
Jun 6, 2019
Merged

exposing rt grant flow as public api#48
SomkaPe merged 2 commits intodevfrom
somkape/enableRtGrant

Conversation

@SomkaPe
Copy link
Copy Markdown
Contributor

@SomkaPe SomkaPe commented Jun 5, 2019

No description provided.

@SomkaPe SomkaPe requested review from henrik-me and sangonzal June 5, 2019 18:29
Copy link
Copy Markdown
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to add a comment explaining that RefreshTokenParameters should only be used for migration purposes, and SilentParameters is the recommended way of refreshing tokens.

@henrik-me
Copy link
Copy Markdown
Contributor

@sangonzal @SomkaPe : this is not just for migration purposes. It's both for migration and integration scenarios. I believe both Python and .NET have a reasonable description of this, it may be worth looking at the words used there.

* @param parameters#scopes scopes of the access request
* @return A {@link CompletableFuture} object representing the {@link IAuthenticationResult} of the call.
*/
CompletableFuture<IAuthenticationResult> acquireToken(RefreshTokenParameters parameters);
Copy link
Copy Markdown
Contributor

@henrik-me henrik-me Jun 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, for pointing out , have copy pasted

@SomkaPe SomkaPe merged commit b3935ee into dev Jun 6, 2019
@SomkaPe SomkaPe deleted the somkape/enableRtGrant branch June 6, 2019 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants