Conversation
| </executions> | ||
| </plugin> | ||
| <plugin> | ||
| <groupId>com.github.spotbugs</groupId> |
There was a problem hiding this comment.
com.github.spotbugs [](start = 25, length = 19)
did you validate that we can use this? Also assuming there is automatic component governance setup for this project? Otherwise pls. ensure this component is properly registered and removed components are de-registered.
There was a problem hiding this comment.
it is plugin - dev tool, yes automatic governance is set up
| @NonNull | ||
| private char[] password; | ||
|
|
||
| public char[] password(){ |
There was a problem hiding this comment.
password [](start = 18, length = 8)
ClonePassword?
There was a problem hiding this comment.
to keep it immutable we should not expose internal representation which is array, so mutable
sangonzal
left a comment
sangonzal
left a comment
There was a problem hiding this comment.
Good improvements. Current PR is set to be merged to Master branch - should be Dev instead
| <version>3.5</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.google.guava</groupId> |
There was a problem hiding this comment.
Guava was added because of the selenium tests: SeleniumHQ/selenium#3880. Please make sure integration tests still work both locally and on Azure Devops
There was a problem hiding this comment.
i have fixed some issued with integ tests, like usage of wrong redirect url(wrong port) and test with device code flow, but one test failing - acquireTokenWithAuthorizationCode_B2C_Google - it was never successfully executed on azure devops
There was a problem hiding this comment.
The B2C_Google test failing on Azure Devops is probably due to Google flagging the test account for "suspicious activity" since the request is coming from completely different place/different IP. When this happens, they ask you to change the password. I'm not sure if there is much that we can do there.
| throw new RuntimeException("Could not start TCP listener"); | ||
| } | ||
| runSeleniumAutomatedLogin(labUserData, authorityType); | ||
| String page = seleniumDriver.getPageSource(); |
There was a problem hiding this comment.
Doesn't seem to be used anywhere.
3 participants
pom.xml - removing unused dependencies, adding scope "test" to test dependencies, removing profiles,
changing find bugs plugin to spot bugs (find bugs is not maintained any more), formatting
fixing some issues found with spot bugs: