Closed
Conversation
|
|
sangonzal
reviewed
Oct 29, 2020
Contributor
sangonzal
left a comment
sangonzal
left a comment
There was a problem hiding this comment.
Thanks @tear-gas. These changes look good to me. Before merging we will have to do some testing to ensure there are no other changes in between oauth2-oidc-sdk 7.4 and 8.22 that could affect MSAL.
|
Would fix #316 |
|
The current version is 8.27 - maybe this could be changed (maybe use https://dependabot.com/ for the project to keep dependencies up to date). |
Contributor
|
Closing this PR, as the issue was resolved by #322 in a different way in the latest release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating com.nimbusds.oauth2-oidc-sdk to version 8.22
Deprecated javax.mail package was removed in version 8. Making changes to use
com.nimbusds.common.contenttype.ContentTypeinstead ofcom.nimbusds.oauth2.sdk.http.CommonContentTypesIssue for reference: https://bitbucket.org/connect2id/oauth-2.0-sdk-with-openid-connect-extensions/issues/195/deprecate-usage-of-javaxmail-package