Skip to content

Enable device code flow for ADFS 2019#241

Merged
Avery-Dunn merged 5 commits intodevfrom
avdunn/adfs-devicecode
Jun 2, 2020
Merged

Enable device code flow for ADFS 2019#241
Avery-Dunn merged 5 commits intodevfrom
avdunn/adfs-devicecode

Conversation

@Avery-Dunn
Copy link
Copy Markdown
Contributor

Allows device code flow to for ADFS users, per #237

  • Adds device code endpoint parameter to Authority objects
  • Changes device code's HTTP request from GET to POST, moves query parameters to body
  • Adds integration test for device code with ADFS user, removes unit tests looking for exception in that situation

@Avery-Dunn Avery-Dunn requested review from SomkaPe and sangonzal May 29, 2020 19:09
@Avery-Dunn Avery-Dunn requested a review from sangonzal June 2, 2020 20:25
Copy link
Copy Markdown
Contributor

@sangonzal sangonzal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

this.deviceCodeEndpoint = String.format(DEVICE_CODE_ENDPOINT_FORMAT, host, tenant);
}


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: extra line

@Avery-Dunn Avery-Dunn merged commit df4e339 into dev Jun 2, 2020
@Avery-Dunn Avery-Dunn deleted the avdunn/adfs-devicecode branch October 13, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants