support for national cloud integ tesing + arlington tests#190
Merged
Conversation
added 2 commits
March 1, 2020 18:27
sangonzal
approved these changes
Mar 2, 2020
| private void runAutomatedDeviceCodeFlow(DeviceCode deviceCode, User user){ | ||
| boolean isRunningLocally = !Strings.isNullOrEmpty( | ||
| System.getenv(TestConstants.LOCAL_FLAG_ENV_VAR)); | ||
| boolean isRunningLocally = true;//!Strings.isNullOrEmpty( |
Contributor
There was a problem hiding this comment.
Please revert this - otherwise the AzureDevops tests will fail. You should be able to just set an environment variable and not have to comment this out.
Contributor
There was a problem hiding this comment.
perhaps the test should say this if this fails... please set this env variable if you are running these tests on your local box?
Contributor
Author
There was a problem hiding this comment.
ok, going to revert it, but it might be not required any more - tests are green
SomkaPe
added a commit
that referenced
this pull request
May 5, 2020
* support for national cloud integ tesing + arlington tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All others flows looks good