Conversation
navyasric
left a comment
navyasric
left a comment
There was a problem hiding this comment.
Looks good. I have left some comments to update aks.ms links to point to docs.
|
|
||
| /** | ||
| * Authorization code acquired in the first step of OAuth2.0 authorization code flow. For more | ||
| * details, see https://aka.ms/msal4j-authorization-code-flow |
There was a problem hiding this comment.
| /** | ||
| * In the context of device code user has not yet authenticated via browser | ||
| * In the context of device code user has not yet authenticated via browser. For more details, | ||
| * see https://aka.ms/msal4j-device-code |
There was a problem hiding this comment.
| /** | ||
| * Factory for creating client credentials used in confidential client flows | ||
| * Factory for creating client credentials used in confidential client flows. For more details, see | ||
| * https://aka.ms/msal4j-client-credentials |
There was a problem hiding this comment.
There was a problem hiding this comment.
The docs link you're pointing to doesn't say anything about ClientCredentialFactory (how to initialize a client credential for confidential clients). The wiki page is more useful.
There was a problem hiding this comment.
Based on the new patterns in the dev samples, we are going to update docs pages. We can probably update the links once the docs pages are updated.
There was a problem hiding this comment.
Sounds good, I'm fine with that.
| * Object containing parameters for Username/Password flow. Can be used as parameter to | ||
| * {@link PublicClientApplication#acquireToken(UserNamePasswordParameters)} | ||
| * | ||
| * For more details, see https://aka.ms/msal4j-username-password |
There was a problem hiding this comment.
|
@navyasric Thanks for reviewing. Yes I plan on changing the redirect links to point to the microsoft docs (other than the client-credentials link) when we update the code snippets. We can update the links at any time on https://aka.ms. I've added the DevexJavaPython security group to the owners for all of these links btw, so any of us can update them at any point |
2 participants
#169 and #75