Conversation
sangonzal
approved these changes
Dec 20, 2019
Contributor
sangonzal
left a comment
sangonzal
left a comment
There was a problem hiding this comment.
Looks good. Just a couple of comments.
| static ObjectMapper mapper = new ObjectMapper() | ||
| .configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); | ||
|
|
||
| static <T> T convertJsonToObject(final String json, final Class<T> clazz) { |
Contributor
There was a problem hiding this comment.
Are you able to use JsonHelper here? Would avoid having duplicate code
Contributor
Author
There was a problem hiding this comment.
will have to make it public
| @@ -0,0 +1 @@ | |||
| lombok.anyConstructor.addConstructorProperties=true No newline at end of file | |||
Contributor
There was a problem hiding this comment.
I'd prefer to have the annotations and constructor than an extra config file.
Contributor
Author
There was a problem hiding this comment.
adding those constructors might be very error prone because it should depend on json properties - so when you add new or remove json property you also need update constructor and keep in in sync
added 2 commits
December 20, 2019 14:58
SomkaPe
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12