Make Account internal. Add ClientCrendential interfaces#119
Merged
Conversation
Contributor
|
Not sure I fully understand all of these changes. Can you pls. highlight why these changes? |
Contributor
|
I think the best way is to ensure there is a meaningful issue which describes this work and what the intention is. Signing off, but please ensure the reasoning why is well described |
Contributor
Author
|
Chatted offline. Documented reasoning for refactoring in #120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last change before cutting 0.7.0-preview