Conversation
sangonzal
commented
Oct 30, 2019
| @Test | ||
| private void acquireTokenSilent_usingCommonAuthority_returnCachedAt() throws Exception { | ||
| acquireTokenSilent_returnCachedTokens(TestConstants.ORGANIZATIONS_AUTHORITY); | ||
| @Test(expectedExceptions = ExecutionException.class) |
Contributor
Author
There was a problem hiding this comment.
This will be updated to MsalException once we start unwrapping exceptions
sangonzal
commented
Oct 30, 2019
|
|
||
| Assert.assertNotNull(result); | ||
| Assert.assertNotNull(result.accessToken()); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
This is an acquireTokenSilent test, so moved to AcquireTokenSilentIT.java
Contributor
|
I'm assuming that a number of samples will also have to be updates as a consequence of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClientAssertionAPI toClientCredentialFactoryClientCredentialFactory.create()toClientCredentialFactory.createFromSecret(),ClientCredentialFactory.createFromCertificate(),ClientCredentialFactory.createFromClientAssertion()AsymmetricKeyCredential,ClientSecret,ClientAssertionconstructors package private, forcing object creation throughClientCredentialFactory