Skip to content

Make Builder constructor private #116

Merged
sangonzal merged 1 commit intodevfrom
sagonzal/MakeBuilderPrivate
Oct 31, 2019
Merged

Make Builder constructor private #116
sangonzal merged 1 commit intodevfrom
sagonzal/MakeBuilderPrivate

Conversation

@sangonzal
Copy link
Copy Markdown
Contributor

Making the PublicClientApplication and ConfidentialClientApplication Builder constructors private. This will force callers to use the static method PublicClientApplication.builder() to create the objects, which is consistent with all of the other Parameter builders

@sangonzal sangonzal requested a review from henrik-me October 30, 2019 18:26
Copy link
Copy Markdown
Contributor

@henrik-me henrik-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sangonzal sangonzal merged commit 70fc909 into dev Oct 31, 2019
@sangonzal sangonzal deleted the sagonzal/MakeBuilderPrivate branch November 22, 2019 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants