Skip to content

Public API refactoring before GA #120

Closed
Closed
Public API refactoring before GA#120
@sangonzal

Description

@sangonzal
sangonzal
opened on Oct 31, 2019
  • IClientApplicationBase should be made internal. Calling applications should use either IPublicClientApplication or IConfidentialClientApplication.
  • Account should be made internal. Account will always be obtained from calling getAccounts() or from IAuthenticationResult, but never created outside of the library. If such a need arises in the future, we can always make it public again (non-breaking change).
  • AsymmetricKeyCredential should be renamed to ClientCertificate. ClientCertificate is simpler, aligns with other libraries, and is the term that is used in documentation.
  • ClientSecret, ClientCertificate, ClientAssertion should be made internal. There is no need to leak out these implementation details. Instead, IClientSecret, IClientCertificate, and IClientAssertion will be added.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions